Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #101

Closed
jho406 opened this issue Oct 8, 2024 · 0 comments · Fixed by #117
Closed

Improve tests #101

jho406 opened this issue Oct 8, 2024 · 0 comments · Fixed by #117
Assignees
@Tresor11

Comments

@jho406
Copy link
Collaborator

jho406 commented Oct 8, 2024 •
edited
Loading

With the merge of #100 we have green tests again, but superglue's test suite could be improved and refactored. The following two files are in need of improvement:

  • spec/features/navigation.spec.jsx
  • NavComponent.spec.jsx

I'm not quite sure where to start with this, but i think starting by getting rid of "bar" and "foo" strings could be a great start as its confusing even to me.
@jho406 jho406 added this to Superglue Oct 8, 2024
@jho406 jho406 converted this from a draft issue Oct 8, 2024
@Tresor11 Tresor11 self-assigned this Oct 16, 2024
@Tresor11 Tresor11 linked a pull request Nov 10, 2024 that will close this issue
Improve variable names in navigation tests #117
Merged
@github-project-automation github-project-automation bot moved this from Ready for contributors to Done in Superglue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tresor11 Tresor11

Labels
None yet
Projects
Superglue
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve variable names in navigation tests thoughtbot/superglue
2 participants
@jho406 @Tresor11