Setup CI via GitHub Actions #410
Conversation
Pulled from https://github.com/thoughtbot/factory_bot/blob/23162d4348ed8b316d36091b0fc734c174be75c3/.github/workflows/build.yml As with factory_bot, we're no longer running against Ruby head, since we don't have a great way to do allowed failures. Closes thoughtbot#395
|
Thanks for revisiting this. I had meant to come back and do this, but I forgot. |
mathieujobin
force-pushed
the
github-actions-mathieu
branch
from
dd664ee to
f72eb1c
Compare
.rubocop.yml
Outdated
| @@ -0,0 +1 @@ | |||
| inherit_from: .rubocop_todo.yml | |||
There was a problem hiding this comment.
This project uses standard, so I don't think we should have any rubocop config. Were you running rubocop directly? That might be why you saw new warnings. Do you see the same warnings if you run bundle exec rake standard?
That might be a good thing to mention in the CONTRIBUTING.md (it's mentioned in the thoughtbot style guide that they use standard, but I don't think that's the first place somebody would look for that information).
There was a problem hiding this comment.
I'll remove them... I just noticed I had to do the ignores via standard...
There was a problem hiding this comment.
I removed the rubocop files and added the ignore via standard-todo
|
All tests passed again ... https://github.com/mathieujobin/factory_bot_rails/actions/runs/4751503955 |
mathieujobin
force-pushed
the
github-actions-mathieu
branch
from
7302187 to
49f9313
Compare
|
All test passed again https://github.com/mathieujobin/factory_bot_rails/actions/runs/4751973742 |
Ran `bundle update` so the dev Gemfile is using the latest versions of everything. As long as the tests pass, this should be fine. This commit also adds the missing Appraisal from #410 (the PR description mentioned that it was missing, but it didn't register for me when I was reviewing the PR).
Ran `bundle update` so the dev Gemfile is using the latest versions of everything. As long as the tests pass, this should be fine. This commit also adds the missing Appraisal from #410 (the PR description mentioned that it was missing, but it didn't register for me when I was reviewing the PR).
Ran `bundle update` so the dev Gemfile is using the latest versions of everything. As long as the tests pass, this should be fine. This commit also adds the missing Appraisal from #410 (the PR description mentioned that it was missing, but it didn't register for me when I was reviewing the PR).
Ran `bundle update` so the dev Gemfile is using the latest versions of everything. As long as the tests pass, this should be fine. This commit also adds the missing Appraisal from #410 (the PR description mentioned that it was missing, but it didn't register for me when I was reviewing the PR).
Having a test for this would have caught the incorrect standard fix from #410 (comment)
Having a test for this would have caught the incorrect standard fix from #410 (comment)
Replacement for #396
Just to get the ball rolling and have CI working again.
I don't use Spring, so I am skipping these two tests.
Robocop also complained, so I fixed the minimum to get a green build.
I didn't update the Appraisal file, honestly, I would remove it and instead have the Gemfile for more dynamic. I think this can be revisited by someone else in the future.
Cheers
Closes #395