ci: Add Rails 7.2 and Ruby 3.3 to testing matrix #1032
Conversation
hasghari
force-pushed
the
intermittent-specs
branch
4 times, most recently
from
edaee0c to
81017f8
Compare
hasghari
force-pushed
the
intermittent-specs
branch
from
5c15357 to
81eae60
Compare
hasghari
force-pushed
the
intermittent-specs
branch
2 times, most recently
from
6a3c5b9 to
aa99de8
Compare
hasghari
changed the title
hasghari
force-pushed
the
intermittent-specs
branch
from
aa99de8 to
28ec39a
Compare
| env["QUERY_STRING"] = Rack::Utils.build_query(params) | ||
| query_string = Rack::Utils.build_query(params) | ||
| env[Rack::QUERY_STRING] = query_string | ||
| env[Rack::RACK_REQUEST_QUERY_STRING] = query_string |
There was a problem hiding this comment.
This fixes the following deprecation warning:
warning: query string used for GET parsing different from current query string. Starting in Rack 3.2, Rack will used the cached GET value instead of parsing the current query string.
295b7eb to
df45d05
Compare
hasghari
force-pushed
the
intermittent-specs
branch
2 times, most recently
from
41e875c to
1046c53
Compare
Use ActiveSupport::Testing::TimeHelpers instead
hasghari
force-pushed
the
intermittent-specs
branch
from
1046c53 to
5fb25a8
Compare
|
There are a number of files deleted in this PR. Could you add a description and some information about what this PR is doing beyond updating the test matrix? |
@sej3506 Sure. I've tried to have descriptive commit messages for each of the 6 commits in this PR. However, the commit with the subject "Use default settings of Rails version under test" is the most substantial one. Many of the deprecation warnings that were produced were a result of testing different versions of Rails with non-default settings. My goal with that specific commit was to set I also wanted to standardize the setup of a dummy application for testing purposes so I generated the dummy application structure by copying the files generated by running |
No description provided.