Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thoughtbot/clearance
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.1
Choose a base ref
...
head repository: thoughtbot/clearance
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.0
Choose a head ref
  • 3 commits
  • 22 files changed
  • 1 contributor

Commits on Dec 20, 2014

  1. Convert to rspec-mocks 

    Another step in modernizing the clearance test suite. We've been using
rspec-mocks on our projects for over a year now.
    @derekprior
    derekprior committed Dec 20, 2014
    Configuration menu
    Copy the full SHA
    32e828c View commit details
    Browse the repository at this point in the history

  2. Support Rails 4.2 

    Most of the changes necessary here were test-suite-only issues. The lone
production-impactful change was adding support for
`ActionMailer#deliver_later` in the `PasswordsController`. This will
automatically use the queue configured with Active Job in order to
background the sending of email. With no queue configured, it will be
delivered synchronously. The old `#deliver` method still works, but
generates deprecation warnings.

The rest of the changes were related to the test suite:
* Add a Rails 4.2 appraisal
* Update cucumber steps to remove unnecessary gems from generated apps.
* Simplify appraisal dependencies thanks to the above.
* Fixed `forgeries_controller_spec`. This is still a brittle way to test
  this functionality but at least it works across Rails versions.
* Removed deprecation related to test suite ordering in the test app
  that is loaded.

There remains a single (repeated) deprecation when running specs on 4.2
which comes from RSpec and will be addressed by upgrading to
`rspec-rails` 3.1 (see [`rspec-rails` issue]. That work will be in a
separate pull-request.

[`rspec-rails` issue]: rspec/rspec-rails#1187
    @derekprior
    derekprior committed Dec 20, 2014
    Configuration menu
    Copy the full SHA
    c3643fe View commit details
    Browse the repository at this point in the history

  3. v1.6.0

    @derekprior
    derekprior committed Dec 20, 2014
    Configuration menu
    Copy the full SHA
    13cc61a View commit details
    Browse the repository at this point in the history
Loading