fix(rstream): Fix unbound this in method call expression #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andrew8er! But this would be shorter: |
|
I have not tested this, but I guess an indirect call via |
|
It's probably slower, but wouldn't matter much here... anyhow, happy to accept as is if you find the other version less readable... (i don't think it is, but hey... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the reject handler of the
Resolver.next()method.Previously, the expression
would call the error method of the prototype if no
this.failwas defined, but without bindingthisto the current object. Thus, the first statement ofSubscription.error()would fail with the following error:TypeError: Cannot set property 'state' of undefined