perf(hiccup): update css()

- use string concat (~2.5x faster) - skip null values
thi-ng · May 12, 2018 · b1cb7d9 · b1cb7d9
1 parent feca566
commit b1cb7d9
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/packages/hiccup/src/css.ts b/packages/hiccup/src/css.ts
@@ -1,15 +1,13 @@
 import { isFunction } from "@thi.ng/checks/is-function";
 
 export const css = (rules: any) => {
-    const css = [];
+    let css = "", v;
     for (let r in rules) {
-        if (rules.hasOwnProperty(r)) {
-            let v = rules[r];
-            if (isFunction(v)) {
-                v = v(rules);
-            }
-            css.push(r + ":" + v + ";");
+        v = rules[r];
+        if (isFunction(v)) {
+            v = v(rules);
         }
+        v != null && (css += `${r}:${v};`);
     }
-    return css.join("");
+    return css;
 };