Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm package needs publishing to include fix for typescript >= 5 #225

Closed
wdoconnell opened this issue Sep 13, 2023 · 8 comments
Closed

npm package needs publishing to include fix for typescript >= 5 #225

wdoconnell opened this issue Sep 13, 2023 · 8 comments

Comments

@wdoconnell
Copy link

This PR #204 (April 1 2023) fixed a check that was causing protoc-gen-ts to decline to run if the user had a typescript version above 5. The fix is in, but protoc-gen-ts and plugins that rely on it won't work until the npm package is updated.

https://www.npmjs.com/package/protoc-gen-ts (last updated Mar. 2023)
@drbild
Copy link

drbild commented Sep 13, 2023 •
edited
Loading

Does this peerDependency need to be updated as well?

@wdoconnell
Copy link
Author

Yes, I think so

@wdoconnell
Copy link
Author

Which folks have authority to handle npm publication?

@thesayyn
Copy link
Owner

Does this peerDependency need to be updated as well?

Can somebody send a PR for this? I'll cut a release after the fix lands.

@wdoconnell
Copy link
Author

@thesayyn thanks very much - I'll push up a PR tomorrow.

@wdoconnell wdoconnell mentioned this issue Sep 15, 2023
Merged
@wdoconnell
Copy link
Author

@thesayyn All set - added a PR for this.

@wdoconnell
Copy link
Author

@thesayyn Is it possible for you to cut a new npm release now that this is merged? Thanks very much.

@thesayyn
Copy link
Owner

https://github.com/thesayyn/protoc-gen-ts/releases/tag/0.8.7 is up

@thesayyn thesayyn mentioned this issue Mar 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drbild @thesayyn @wdoconnell