Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated protoc-gen-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." #203

Closed
danias opened this issue Apr 1, 2023 · 7 comments
Closed

Updated protoc-gen-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." #203

danias opened this issue Apr 1, 2023 · 7 comments

Comments

@danias
Copy link

danias commented Apr 1, 2023 •
edited
Loading

Updated protoc-gen-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting the error:

--ts_out: protoc-gen-ts requires TypeScript 4.9 or above.

Tried to delete node_modules and do yarn again but still getting the same error. Any ideas?
@danias danias changed the title Updated proto-get-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." Updated protoc-get-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." Apr 1, 2023
@danias danias changed the title Updated protoc-get-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." Updated protoc-gen-ts to version 0.8.5 and TypeScript to version 5.0.3 but still getting "--ts_out: protoc-gen-ts requires TypeScript 4.9 or above." Apr 1, 2023
danias added a commit to danias/protoc-gen-ts that referenced this issue Apr 1, 2023
@danias
Fixes issue thesayyn#203
f2a66c6
@danias danias mentioned this issue Apr 1, 2023
Merged
@flyingsilverfin flyingsilverfin mentioned this issue Jul 17, 2023
Closed
@lantos1618
Copy link

is this mergeable?

@sbussard
Copy link

sbussard commented Aug 2, 2023

Was the fix not merged? I'm getting the same error

@sbussard
Copy link

sbussard commented Aug 2, 2023

It looks like the latest code hasn't been pushed to npm

@soluwalana
Copy link

Do we have an estimate for when 0.8.7 will be released to NPM?

@jasgeo75
Copy link

jasgeo75 commented Aug 14, 2023 •
edited
Loading

seems this still hasn't been published. seems to work fine if you patch it yourself. (edit)

@scippio
Copy link

scippio commented Aug 18, 2023 •
edited
Loading

Still using old version?

$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: project@0.0.1
npm ERR! Found: typescript@5.1.6
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"5.1.6" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"4.x.x" from protoc-gen-ts@0.8.6
npm ERR! node_modules/protoc-gen-ts
npm ERR!   dev protoc-gen-ts@"0.8.6" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR!

...

--ts_out: protoc-gen-ts requires TypeScript 4.9 or above.

@wdoconnell wdoconnell mentioned this issue Sep 15, 2023
Merged
@thesayyn
Copy link
Owner

This is fixed with the rust rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sbussard @soluwalana @scippio @danias @thesayyn @jasgeo75 @lantos1618