Fixed invalid body_markdown in article with video #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @araslanov-e, it's not clear to me what the fix is :) Is it about indentation in the creation service body markdown strings? |
|
I'm looking for a solution for MarkdownFixer, there are more tests and a clearer problem |
|
@araslanov-e sorry, I wasn't clear, I was referring to the diff, what is not clear to me is where the fix is in the code :) The code on the left looks a lot similar to the code you changed, that's why I was asking! |
|
@rhymes Aaa, sorry. There was no space before after |
7 tasks
maestromac
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Wow, I can't believe this is the cause of this issue.
Thanks for fixing this @araslanov-e , LGTM!
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
RakChamp25
pushed a commit
to RakChamp25/dev.to
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
After upload video creates an article with body_markdown with an empty description and failed to parse tags
Related Tickets & Documents
#3846
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?