Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chat/userDetails.jsx #4241

Closed
wants to merge 11 commits into from
Closed

Refactor chat/userDetails.jsx #4241

wants to merge 11 commits into from

Conversation

hoangvvo
Copy link
Contributor

@hoangvvo hoangvvo commented Oct 5, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Attempt to clear up as much as possible this codeClimate issue by abstracting socialIcons, userLocation, block&report buttons and userDetails modals.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

cleannnn

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 5, 2019
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2019

CLA assistant check
All committers have signed the CLA.

@hoangvvo
Copy link
Contributor Author

hoangvvo commented Oct 5, 2019

Related to #3739

@hoangvvo hoangvvo changed the title Refactor userDetails.jsx [WIP] Refactor userDetails.jsx Oct 5, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Oct 5, 2019
@hoangvvo
Copy link
Contributor Author

hoangvvo commented Oct 5, 2019

Ooops, I did not know Fragment is not supported in preact, but it seems to be supported in Preact X. Obviously, this can be overcomed easily but would love to know if there is any plan for update.

@hoangvvo hoangvvo changed the title [WIP] Refactor userDetails.jsx Refactor userDetails.jsx Oct 5, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 5, 2019
@hoangvvo hoangvvo changed the title Refactor userDetails.jsx Refactor chat/userDetails.jsx Oct 5, 2019
@hoangvvo
Copy link
Contributor Author

Closing since this PR is outdated

@hoangvvo hoangvvo closed this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: unreviewed bot applied label for PR's with no review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants