[WIP] fixed es-lint issues #4223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @uchihamalolan , are you still working on this PR? |
|
No, sorry. I didn't have time
…On Tue, Dec 17, 2019 at 1:49 AM Mac Siri ***@***.***> wrote:
Hello @uchihamalolan <https://github.com/uchihamalolan> , are you still
working on this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4223>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3CPCUQAUWJRTMGQYFLZNLQY7PFZANCNFSM4I5KAASA>
.
|
|
That's alright @uchihamalolan . I am going to close this PR for the time being then. Thank you for opening this PR and I'm happy to reopen this again if you ever feel like picking this back up again in the future. Also, the smaller the PR the easier it is to be merged 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixed es-lint issues
Related Tickets & Documents
Lint issues with JavaScript Files (#3777)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
NA
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?