fixes bug in tag search feature #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now allows user to type in full name of tag and it does not disappear makes other changes to pass eslint failing tests moves methods around according to eslint tests makes use of prevState callback method due to eslint tests
|
|
removes complex logical expression comparison from !== to != changes made due to failing task in pull request
nickytonline
reviewed
Oct 4, 2019
rhymes
reviewed
Oct 7, 2019
There was a problem hiding this comment.
Great job @torianne02 and great catch!
I've added some notes and a question but I've also tested it locally and it looks okay.
I'll wait for your feedback and then approve it!
updates logic to fix searchResults removes .filter()
rhymes
approved these changes
Oct 8, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
RakChamp25
pushed a commit
to RakChamp25/dev.to
that referenced
this pull request
Oct 15, 2019
* fixes bug in tag search feature now allows user to type in full name of tag and it does not disappear makes other changes to pass eslint failing tests moves methods around according to eslint tests makes use of prevState callback method due to eslint tests * updates handleKeyDown method removes complex logical expression comparison from !== to != changes made due to failing task in pull request * removes commented out code that I added to test code updates logic to fix searchResults removes .filter() * adds comments to fixed code for clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When typing in tags using the v2 editor, the tag disappears once you've typed in the full word. For example, if you want to type in
javascriptit will appear as a choice all the way up until you add thetat the end of the word which causes it to disappear from the choice list.In order to fix this functionality I added an
ORstatement to the search method in the app/javascript/shared/components/tags.jsx file.I also made a few fixes to this file according to the eslint recommendations. They were minor changes, such as using
prevStatecallback and reordering methods. Another suggestion from eslint that I implemented was to change all!=comparison to!==.A possible future edit could be to make sure a tag doesn't appear once it's already been chosen when searching. I'd be glad to work on that logic as well if needed.
Related Tickets & Documents
Someone reported the bug as a triage issue. The link to this is here.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
My first open source pull request!!!!