Make Onboarding Compatible With All Themes (#3604) #4196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
batary seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I must've committed changes on a computer that didn't have git set up properly so I'm going to close and recreate this PR so the CLA works properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Updated the styles in
app/assets/stylesheets/preact/onboarding-modal.scssto support all themes. I tried to keep all of the default colors intact, so if the default theme is selected, it looks pretty much the same as it used to.A couple of things I ran into:
input[type='checkbox']:checkedbackground used to be set to--theme-top-bar-write-background, but the minimal light theme uses white for that variable, so I changed it to use--theme-anchor-colorinstead./assets/mobile-onboarding-background.pngbackground image for the mobile view has a slightly transparent white background on it, which makes it difficult to read white text even when the background is dark (see the dark mobile theme screenshot below), so I've set the text color for that part to use$blackfor mobile regardless of theme.Related Tickets & Documents
#3604 - Make Onboarding Compatible With All Themes
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?