Fixes Dev listings button color in pink theme #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue 3667 🍾 |
|
@Aswathprabhu thanks for your contribution, can you provide a screenshot just in case? thanks! |
Sure @rhymes
|
Glennmen
reviewed
Oct 2, 2019
| @include themeable( | ||
| background-color, | ||
| theme-container-accent-background, | ||
| $white |
There was a problem hiding this comment.
This doesn't seem right 🤔Both default value for color and background-color are $white
There was a problem hiding this comment.
@Glennmen thanks for spotting this! I've fixed this now 👍
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Dev listings button color in pink theme
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Closes #3667
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?