Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and mechanical mistakes [ci skip] #4177

Merged

Conversation

jacobherrington
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Had some time on my hands so did a quick audit for fairly obvious
mechanical and grammatical issues in the development docs.

This should be mostly fixing things like commas and periods, but once or
twice I had to swap a word or two.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Homer stressed and reading

Had some time on my hands so did a quick audit for fairly obvious
mechanical and grammatical issues in the development docs.

This should be mostly fixing things like commas and periods, but once or
twice I had to swap a word or two.
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 1, 2019
@@ -8,11 +8,11 @@ DEV allows you to authenticate using GitHub. To use this authentication method i

1. [Click this link to create a new OAuth application in your Github account](https://github.com/settings/applications/new) - you will be redirected to sign in to Github account if you have not already.

2. Fill in the form with an application name, description and the URL `http://localhost:3000/`. Replace the port `3000` if you run DEV on another port.
2. Fill in the form with an application name, description, and the URL `http://localhost:3000/`. Replace the port `3000` if you run DEV on another port.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Oxford Comma

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 1, 2019
@maestromac maestromac merged commit 4ea1e6e into forem:master Oct 1, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 1, 2019
redbassett pushed a commit to redbassett/dev.to that referenced this pull request Oct 3, 2019
@jacobherrington jacobherrington deleted the doc/mechanical-and-grammar-audit branch October 24, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants