Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust css bottom value for notifications menu #4167

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

mooreInteractive
Copy link
Contributor

@mooreInteractive mooreInteractive commented Oct 1, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Adjusting the notifcations options menu on a post. Was set to -155px, but likely changed the number of items in the list recently, and needs a bit more space. Setting to -185px seems to do the trick.

Related Tickets & Documents

#4097

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:
before

After:
after

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 1, 2019
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 7, 2019
@rhymes rhymes changed the title adjust css bottom value for notifcations menu adjust css bottom value for notifications menu Oct 7, 2019
@maestromac maestromac merged commit 0b8b00c into forem:master Oct 7, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 7, 2019
RakChamp25 pushed a commit to RakChamp25/dev.to that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants