Bug/fixes links without http(s) #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks for the contribution @Amorpheuz, in addition to improving the regexp I suggest you add tests about this, being such a crucial part of the rendering process.
You can add specs to https://github.com/thepracticaldev/dev.to/blob/master/spec/labor/markdown_parser_spec.rb which uses this class to render things
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
rhymes
suggested changes
Oct 4, 2019
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
rhymes
approved these changes
Oct 5, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fix invalid links in article/comments due to absence of http/https
app>lin>redcarpet>render>html_rouge.rbhttps://orhttp://or isnil.Related Tickets & Documents
#4101
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
Figured out a way to test WSL changes via travis 🎉. After ditching a previous branch, hehe.
