Get a shallow list of objects in listContents #47
Conversation
|
I've confirmed this patch to be much much much faster then before. Thnx! |
|
@zaak I'm doing some research of my own as well, I know that this implementation might have the 1000 object limit, which is something the iterator works around. Might be that we'll need to file an issue for this and require at least the next version or implement it ourselves. |
|
@frankdejonge Good to know. I'll have a look at this too. |
|
@frankdejonge I've updated the PR (just to let you know what I found). Looks like paginators may be the way to go. Seems to work fine with > 1000 objects, but I didn't do too much testing yet. |
|
this works fine (a tests fails though) - is this to be released anytime soon? |
|
@basz Which tests fails? Edit: Never mind, I got it. |
|
Updated the PR. It's kinda tricky to test it properly due to internal closure, but I think it's worth to keep the logic this way and allow requests to be sent asynchronously. |
Get a shallow list of objects in listContents
This is a performance improvement like in thephpleague/flysystem-aws-s3-v2#13.
With AWS-SDK v3 it's not possible to pass
return_prefixesiterator option, so I had to process the command manually. Actually it may be even more efficient as there's no unnecessary array to iterator, and then back iterator to array conversion.