This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
Fix "Return value must be of the type int" on Symfony 5.3 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the bundle currently doesn't support Symfony < 4.4, and returning 0 is already supported there, we can simply always return 0
|
Thank you @yched, sorry for the late check |
kgust
pushed a commit
to kgust/PsyshBundle
that referenced
this pull request
Feb 9, 2022
Since the bundle currently doesn't support Symfony < 4.4, and returning 0 is already supported there, we can simply always return 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Since the bundle currently supports Symfony >= 4.4, and returning 0 is already supported in 4.4,
we can simply always return 0