Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

Make psysh.facade public so it is not removed from the compiled container #31

Merged
merged 3 commits into from
Dec 17, 2017
Merged

Conversation

msheakoski
Copy link

Fix for error in Symfony 4: The "psysh.facade" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

@theofidry
Copy link
Owner

theofidry commented Dec 11, 2017

Thanks for the PR! Looks like there is an issue with PHP 5.6... Maybe we could drop it and push 7.1 for the new versions

@msheakoski
Copy link
Author

msheakoski commented Dec 11, 2017

It looks like a Composer or PHP configuration issue, not anything bundle-related:

PHP Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 12288 bytes) in phar:///home/travis/.phpenv/versions/5.6.31/bin/composer/src/Composer/DependencyResolver/Transaction.php on line 63

@msheakoski
Copy link
Author

If you have a way to trigger the build again, please do so. Maybe the server was out of available resources.

@theofidry
Copy link
Owner

theofidry commented Dec 11, 2017 via email

@Kocal
Copy link

Kocal commented Dec 16, 2017

msheakoski and others added 3 commits December 17, 2017 21:55
Fix for error in Symfony 4: The "psysh.facade" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.
- Update PHPUnit to 6.x
- Move AppKernel in a namespace and leverage the Composer PSR-4
  autoloader and the KERNEL_CLASS environment varaible
- Make the necessary services public
@theofidry theofidry merged commit 23409c7 into theofidry:master Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants