IOPS-1870 Allow Van as surname when only surname #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@estringana, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wyrfel to be a potential reviewer. |
estringana
force-pushed
the
hotfix/OPS-1870-Allow-Van-as-Surname
branch
from
f3fc3bf to
df4233a
Compare
src/Part/Lastname.php
Outdated
| return static::$prefixes[self::getKey($value)]; | ||
| } | ||
|
|
||
| return $this->camelcase($this->getValue()); | ||
| } | ||
|
|
||
| public function setAsNotPrefix() |
It was detected that Van was always detected as prefix of surname. However, it did not make sense to have a prefix without a surname. This PR fixes that, it checks if it is the only surname and if it is, it get the only surname as surname without paying attention to the prefixes.
estringana
force-pushed
the
hotfix/OPS-1870-Allow-Van-as-Surname
branch
from
df4233a to
1124002
Compare
wyrfel
approved these changes
Aug 14, 2017
pierswarmers
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was detected that Van was always detected as prefix of surname.
However, it did not make sense to have a prefix without a surname.
This PR fixes that, it checks if it is the only surname and if it
is, it get the only surname as surname without paying attention
to the prefixes.