Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message customization #9

Closed
wants to merge 1 commit into from

Conversation

jcw-
Copy link
Contributor

@jcw- jcw- commented Nov 22, 2021

New

  • Adds the ability to optionally customize the success and failure messages.
  • Adds the ability to optionally add a notice upon failure (for printing out the guidelines).
  • Removes "title needs formatting" label if PR has an ignore label applied
  • Backwards compatible, defaults to current messages if the new config section isn't found

Fixes

  • removeLabel had an unreferenced variable usage in the error handling
  • adds a missing await when invoking addLabel
  • no longer prints out success message when there's a failure

Refactored

  • pulled failure handling out of addLabel and into a new function called titleCheckFailed

@jcw- jcw- marked this pull request as ready for review November 22, 2021 06:29
@jcw- jcw- marked this pull request as draft November 22, 2021 06:41
@jcw- jcw- force-pushed the add-message-customizatio branch 2 times, most recently from 0acd17a to c8455fc Compare November 22, 2021 07:26
@jcw- jcw- marked this pull request as ready for review November 22, 2021 07:44
@jcw- jcw- force-pushed the add-message-customizatio branch 2 times, most recently from b1d9b90 to 855094a Compare November 22, 2021 08:37
@jcw- jcw- force-pushed the add-message-customizatio branch from 855094a to e7ad3c2 Compare November 22, 2021 08:54
@thehanimo
Copy link
Owner

Thank you so much for this @jcw-! There was a typo in the branch name so I've renamed it, made a few changes and merged this via #10. Released v1.3.3!

@thehanimo thehanimo closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants