Fix share link building when params particle is present
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these cases the site permalink is used instead of the social network URL for sharing as defined in the `link` value (https://www.linkedin.com/shareArticle in the below example) Most visible case is LinkedIn but all social networks that have ```toml [ananke.social.networks.particles] ... params = "..." ``` in `config/_default/params.toml` are affected by this bug.
✅ Deploy Preview for ananke-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidsneighbour
approved these changes
Oct 25, 2024
ramiro
deleted the
fix-share-link-building-when-params-particle-is-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these cases the site permalink is used instead of the social network URL for sharing as defined in the
linkvalue(https://www.linkedin.com/shareArticle in the below example)
Most visible case is LinkedIn but all social networks that have
in
config/_default/params.tomlare affected by this bug.Closes #768.