Add transform.Plainify to the summary body content of the share links #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melroy van den Berg <melroy@melroy.org>
melroy89
referenced
this pull request
Oct 22, 2024
Signed-off-by: Patrick Kollitsch <patrick@davids-neighbour.com>
✅ Deploy Preview for ananke-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The HTMLEscape is there so that special characters are escaped. There is a function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You definitely want to add Plainify transformer first, because the body content will become a HTML encoding mess. I left
HTMLEscapethere as well, just be sure for security reasons. But if you want, I can remove the second transformer.Like a tweet on X will look like this:
After implementing
transform.Plainify, it will look much better:(ignore the red, I don't have X premium pro blabla, it's red because I hit the max limit of chars)