-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution: fix hard-coded link to section #664 #665
Merged
regisphilibert
merged 4 commits into
theNewDynamic:master
from
Blackstareye:f/allow_multiple_mainsections
Apr 18, 2024
Merged
Contribution: fix hard-coded link to section #664 #665
regisphilibert
merged 4 commits into
theNewDynamic:master
from
Blackstareye:f/allow_multiple_mainsections
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gohugo-ananke-theme-demo canceled.
|
@budparr I might need some help on this one. |
If you need any help from my side, just mention me :) |
ramiro
added a commit
to ramiro/gohugo-theme-ananke
that referenced
this pull request
Apr 25, 2024
A bare bones setup of two pages and two posts gets broken because of a missed template change in theNewDynamic#665 Steps to reproduce: ```shell hugo new site quickstart cd quickstart git init git submodule add https://github.com/theNewDynamic/gohugo-theme-ananke.git themes/ananke echo "theme = 'ananke'" >> hugo.toml echo -e "+++\ntitle='Home'\n+++\n\nMain page" > content/_index.md echo Foo. > content/page1.md echo Bar > content/page2.md mkdir -p content/post echo "First post." > content/post/post1.md echo "Second post." > content/post/post2.md hugo server Watching for changes in /Users/ramiro/Personal/tmp/quickstart/{archetypes,assets,content,data,i18n,layouts,static,themes} Watching for config changes in .../quickstart/hugo.toml, ...quickstart/themes/ananke/config.yaml Start building sites … hugo v0.125.3-474c4c02212cf97712c6fbf4159c68822ea6e078+extended darwin/amd64 BuildDate=2024-04-22T17:18:35Z VendorInfo=brew Built in 67 ms Error: error building site: render: failed to render pages: render of "home" failed: ".../quickstart/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ```
ramiro
added a commit
to ramiro/gohugo-theme-ananke
that referenced
this pull request
Apr 25, 2024
A bare bones setup of two pages and two posts gets broken because of a missed template change in theNewDynamic#665 Steps to reproduce: ```shell hugo new site quickstart cd quickstart git init git submodule add https://github.com/theNewDynamic/gohugo-theme-ananke.git themes/ananke echo "theme = 'ananke'" >> hugo.toml echo -e "+++\ntitle='Home'\n+++\n\nMain page" > content/_index.md echo Foo. > content/page1.md echo Bar > content/page2.md mkdir -p content/post echo "First post." > content/post/post1.md echo "Second post." > content/post/post2.md hugo server Watching for changes in .../quickstart/{archetypes,assets,content,data,i18n,layouts,static,themes} Watching for config changes in .../quickstart/hugo.toml, ...quickstart/themes/ananke/config.yaml Start building sites … hugo v0.125.3-474c4c02212cf97712c6fbf4159c68822ea6e078+extended darwin/amd64 BuildDate=2024-04-22T17:18:35Z VendorInfo=brew Built in 67 ms Error: error building site: render: failed to render pages: render of "home" failed: ".../quickstart/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ```
ramiro
added a commit
to ramiro/gohugo-theme-ananke
that referenced
this pull request
Apr 25, 2024
A bare bones setup of two pages and two posts gets broken because of a template change missed in theNewDynamic#665 Fatal error message in readable form: ``` ERROR render: failed to render pages: render of "home" failed: "/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ``` Steps to reproduce: ```shell hugo new site quickstart cd quickstart git init git submodule add https://github.com/theNewDynamic/gohugo-theme-ananke.git themes/ananke echo "theme = 'ananke'" >> hugo.toml echo -e "+++\ntitle='Home'\n+++\n\nMain page" > content/_index.md echo Foo. > content/page1.md echo Bar > content/page2.md mkdir -p content/post echo "First post." > content/post/post1.md echo "Second post." > content/post/post2.md hugo server Watching for changes in .../quickstart/{archetypes,assets,content,data,i18n,layouts,static,themes} Watching for config changes in .../quickstart/hugo.toml, ...quickstart/themes/ananke/config.yaml Start building sites … hugo v0.125.3-474c4c02212cf97712c6fbf4159c68822ea6e078+extended darwin/amd64 BuildDate=2024-04-22T17:18:35Z VendorInfo=brew Built in 67 ms Error: error building site: render: failed to render pages: render of "home" failed: ".../quickstart/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ```
This was referenced Apr 25, 2024
ramiro
added a commit
to ramiro/gohugo-theme-ananke
that referenced
this pull request
Apr 30, 2024
This reverts commit bbd9d80.
ramiro
added a commit
to ramiro/gohugo-theme-ananke
that referenced
this pull request
Apr 30, 2024
… (theNewDynamic#665)" This reverts commit f34c219.
regisphilibert
pushed a commit
that referenced
this pull request
May 3, 2024
A bare bones setup of two pages and two posts gets broken because of a template change missed in #665 Fatal error message in readable form: ``` ERROR render: failed to render pages: render of "home" failed: "/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ``` Steps to reproduce: ```shell hugo new site quickstart cd quickstart git init git submodule add https://github.com/theNewDynamic/gohugo-theme-ananke.git themes/ananke echo "theme = 'ananke'" >> hugo.toml echo -e "+++\ntitle='Home'\n+++\n\nMain page" > content/_index.md echo Foo. > content/page1.md echo Bar > content/page2.md mkdir -p content/post echo "First post." > content/post/post1.md echo "Second post." > content/post/post2.md hugo server Watching for changes in .../quickstart/{archetypes,assets,content,data,i18n,layouts,static,themes} Watching for config changes in .../quickstart/hugo.toml, ...quickstart/themes/ananke/config.yaml Start building sites … hugo v0.125.3-474c4c02212cf97712c6fbf4159c68822ea6e078+extended darwin/amd64 BuildDate=2024-04-22T17:18:35Z VendorInfo=brew Built in 67 ms Error: error building site: render: failed to render pages: render of "home" failed: ".../quickstart/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ```
regisphilibert
pushed a commit
that referenced
this pull request
May 3, 2024
A bare bones setup of two pages and two posts gets broken because of a template change missed in #665 Fatal error message in readable form: ``` ERROR render: failed to render pages: render of "home" failed: "/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ``` Steps to reproduce: ```shell hugo new site quickstart cd quickstart git init git submodule add https://github.com/theNewDynamic/gohugo-theme-ananke.git themes/ananke echo "theme = 'ananke'" >> hugo.toml echo -e "+++\ntitle='Home'\n+++\n\nMain page" > content/_index.md echo Foo. > content/page1.md echo Bar > content/page2.md mkdir -p content/post echo "First post." > content/post/post1.md echo "Second post." > content/post/post2.md hugo server Watching for changes in .../quickstart/{archetypes,assets,content,data,i18n,layouts,static,themes} Watching for config changes in .../quickstart/hugo.toml, ...quickstart/themes/ananke/config.yaml Start building sites … hugo v0.125.3-474c4c02212cf97712c6fbf4159c68822ea6e078+extended darwin/amd64 BuildDate=2024-04-22T17:18:35Z VendorInfo=brew Built in 67 ms Error: error building site: render: failed to render pages: render of "home" failed: ".../quickstart/themes/ananke/layouts/index.html:48:23": execute of template failed: template: index.html:48:23: executing "main" at <.Site.GetPage>: can't evaluate field Site in type string ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#664 describes it.
https://github.com/theNewDynamic/gohugo-theme-ananke/blob/c086834f0ebfa39b8b6b0cfed010588a6907a91c/layouts/index.html#L13C31-L13C31
At the moment, only the first mainsection will be shown in the index.
I changed it so that the mainsections will be iterated with "range $mainsections".
This allows that multiple sections are possible and can be displayed.