Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for img width #481

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

tlindsay42
Copy link
Contributor

Fixes #480

@tlindsay42
Copy link
Contributor Author

Ready for review @regisphilibert

@regisphilibert
Copy link
Member

@budparr I've got a good feeling about this PR, but I'd rather you and your tachyon experience double check.

@tlindsay42
Copy link
Contributor Author

@budparr?

Copy link
Member

@budparr budparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I'm trying to think of cases where users would not be using the shortcode and if we need to mention anything in documentation.

@regisphilibert regisphilibert merged commit 5de8db3 into theNewDynamic:master Feb 2, 2022
@tlindsay42 tlindsay42 deleted the nested-img branch February 2, 2022 18:12
Remicck pushed a commit to Remicck/gohugo-theme-ananke that referenced this pull request Mar 7, 2022
Co-authored-by: Regis Philibert <login@regisphilibert.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

figure shortcode respects height, but ignores width
3 participants