Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song lyrics #139

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Song lyrics #139

merged 5 commits into from
Aug 22, 2018

Conversation

abhimanyuthakre
Copy link
Collaborator

Get song lyrics using "lyrics song_name". User can specify more details like "lyrics song_name movie/album"

Copy link

@sara-02 sara-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good, but I am not keen on using this implementation. Do we have any other way of getting the lyrics, rather than a raw Google search?

@@ -94,6 +95,7 @@ The commands for the various functions are as follows:
* "***Who are you/Identify Youself/What is your name***" for B.E.N.J.I. to introduce itself.
* Face detection feature will automatically fetch image for first time user. From next time, it will predict the authenticity of user. If user is authenticated, then B.E.N.J.I. will start running. If user wants to add another user, he/she can use "***face*** username". By default, username is "admin". So, make sure, while adding a new user, use "username" other than "admin". B.E.N.J.I. will fetch a single image of the user and store it in "dataset" folder in "C" drive.
NOTE: Make sure that system is able to fetch a good image of yours(be in a good lighting conditions). You can also directly add image to "dataset" folder in "C" drive.
* "***lyrics*** _SongName_" gives lyrics of the mentioned song. If required, more details can be provided after the _SongName_.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please specify the format of "more" details. eg: abc movie:123 or abc 123 or abc album 123

windows/benji.py Outdated
link = '+'.join(link[1:])
link = link.replace('+',' ')
title = link[1:]
goog_search = "https://www.google.com/search?sclient=psy-ab&client=ubuntu&hs=k5b&channel=fs&biw=1366&bih=648&noj=1&q=" + title + "lyrics"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a better way of finding the lyrics than scrapping google result?
Also, client=ubuntu is not a constant parameter.

@sara-02
Copy link

sara-02 commented Aug 21, 2018

@the-ethan-hunt What are your thoughts?

@abhimanyuthakre
Copy link
Collaborator Author

Made requested changes to the activities.md. Removed unnecessary parameters in query search.
@sara-02 I previously asked about this same feature and @the-ethan-hunt asked me to do something similar to Shazam. I tried using acrcloud api but could not fetch any results. One other thing I tried is showing lyrics in the GUI itself but the library had some issues(showed wrong results) when I tested the function. I used "lyricswiki" for it. So this seems other alternative wherein the lyrics are accurate.

@the-ethan-hunt
Copy link
Owner

@sara-02 we can work on this one right now. Once we get something better, we can replace it.
@abhimanyuthakre can we work on sound recognition for this in future? IMO, would seem a better concept for the feature. (just a thought)

@the-ethan-hunt the-ethan-hunt merged commit 361f669 into the-ethan-hunt:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants