-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Song lyrics #139
Song lyrics #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is good, but I am not keen on using this implementation. Do we have any other way of getting the lyrics, rather than a raw Google search?
windows/activities.md
Outdated
@@ -94,6 +95,7 @@ The commands for the various functions are as follows: | |||
* "***Who are you/Identify Youself/What is your name***" for B.E.N.J.I. to introduce itself. | |||
* Face detection feature will automatically fetch image for first time user. From next time, it will predict the authenticity of user. If user is authenticated, then B.E.N.J.I. will start running. If user wants to add another user, he/she can use "***face*** username". By default, username is "admin". So, make sure, while adding a new user, use "username" other than "admin". B.E.N.J.I. will fetch a single image of the user and store it in "dataset" folder in "C" drive. | |||
NOTE: Make sure that system is able to fetch a good image of yours(be in a good lighting conditions). You can also directly add image to "dataset" folder in "C" drive. | |||
* "***lyrics*** _SongName_" gives lyrics of the mentioned song. If required, more details can be provided after the _SongName_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please specify the format of "more" details. eg: abc movie:123
or abc 123
or abc album 123
windows/benji.py
Outdated
link = '+'.join(link[1:]) | ||
link = link.replace('+',' ') | ||
title = link[1:] | ||
goog_search = "https://www.google.com/search?sclient=psy-ab&client=ubuntu&hs=k5b&channel=fs&biw=1366&bih=648&noj=1&q=" + title + "lyrics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a better way of finding the lyrics than scrapping google result?
Also, client=ubuntu is not a constant parameter.
@the-ethan-hunt What are your thoughts? |
Made requested changes to the activities.md. Removed unnecessary parameters in query search. |
@sara-02 we can work on this one right now. Once we get something better, we can replace it. |
Get song lyrics using "lyrics song_name". User can specify more details like "lyrics song_name movie/album"