Added pylinter.sh and setup.cfg #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pylinter.sh and setup.cfg added to the project which automatically checks for linting issues so contributors can fix them. Fixes: the-ethan-hunt#129
sara-02
suggested changes
Jul 18, 2018
setup.cfg
Outdated
| ignore = W504 | ||
| max-line-length = 80 | ||
|
|
||
|
|
There was a problem hiding this comment.
please remove this extra new line from here.
pylinter.sh
Outdated
| VIRTUALENV=$(which venv-3) | ||
| fi | ||
|
|
||
| ${VIRTUALENV} python3 -m venv mybenjienv && source myenv/bin/activate && python3 "$(which pip3)" install pycodestyle |
There was a problem hiding this comment.
Since you are naming your venv mybenjienv, source should also use the same name and not myenv
|
Sorry for those silly mistakes will fix them now. |
sara-02
approved these changes
Jul 18, 2018
|
@the-ethan-hunt We are good to merge this now. |
|
Fixes issue #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a bash script for checking for linting errors.