Twitter feature enhanced #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sara-02
suggested changes
Jul 13, 2018
windows/activities.md
Outdated
| @@ -80,7 +80,7 @@ List of the things that B.E.N.J.I. can do: | |||
| * Create a file(txt, docx, pptx,xlsx, vsdx and rtf supported) | |||
| * Podcast | |||
| * Calculator | |||
| * Get top 10 tweets | |||
| * Twitter(get top 10 tweets, get friends) | |||
There was a problem hiding this comment.
get friend's tweets, or get follower list Twitter does have a concept of friends, only follower and following. 😛
windows/activities.md
Outdated
|
|
||
| * "***get tweets***" Get latest 10 tweets from timeline. For this an app is to be registered at https://apps.twitter.com/ (if confused, have a look at https://spring.io/guides/gs/register-twitter-app/). A new file named "twitterCredentials.py" is to be made in the windows folder. Save the consumer key, consumer secret, access token, access token secret with the names consumer_key, consumer_secret, access_token, access_secret repectively in the "twitterCredentials.py". Speak/type "get tweets" and top 10 tweets will be shown, also when and by whom it was created. | ||
| * Get latest 10 tweets done by the user. Speak/type "get my tweets" and top 10 tweets done by the user(you) will be shown with the time when it was tweeted | ||
| * You can get a list of your friends(everyone you follow) from twitter by saying "get twitter friends" or "get my twitter friends" |
There was a problem hiding this comment.
Again using the term friends with Twitter is a misnomer, maybe we should do You can get a list of everyone you follow from twitter by saying "get people I follow on twitter"
windows/benji.py
Outdated
| print("By ", status.user.screen_name, " at ", status.user.created_at) | ||
|
|
||
| #Get friends from twitter | ||
| elif link[-2] == "twitter" and link[-1] == "friends": |
There was a problem hiding this comment.
I assume we will have to change this w.r.t following and not friends
|
@sara-02 have made the suggested changes :) |
sara-02
approved these changes
Jul 13, 2018
|
@sara-02 I am sure you have properly reviewed the PR. Should we merge it? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following enhancements are made:
Say "get my tweets" to get top 10 tweets made by the user.
Say "get my twitter friends" or "get twitter friends" to get a list of everyone you follow on twitter.