fix for that motioned in https://github.com/tesseract-ocr/tesseract/issues/3680 #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
reviewed
Dec 18, 2021
CMakeLists.txt
Outdated
Comment on lines
724
to
732
| # fix for that motioned in https://github.com/tesseract-ocr/tesseract/issues/3680 | ||
| # | ||
| # 2021-12-18 14:56:11 UTC leleliu008@gmail.com | ||
| # | ||
| # Reference: | ||
| # https://github.com/Kitware/CMake/blob/master/Modules/Platform/Android-Determine.cmake | ||
| # https://android.googlesource.com/platform/ndk/+/master/build/cmake/android.toolchain.cmake | ||
| # https://developer.android.com/ndk/guides/cpu-features#the_google_cpu_features_library | ||
| # https://github.com/google/cpu_features#android-ndks-drop-in-replacement |
There was a problem hiding this comment.
Suggested change
| # fix for that motioned in https://github.com/tesseract-ocr/tesseract/issues/3680 | |
| # | |
| # 2021-12-18 14:56:11 UTC leleliu008@gmail.com | |
| # | |
| # Reference: | |
| # https://github.com/Kitware/CMake/blob/master/Modules/Platform/Android-Determine.cmake | |
| # https://android.googlesource.com/platform/ndk/+/master/build/cmake/android.toolchain.cmake | |
| # https://developer.android.com/ndk/guides/cpu-features#the_google_cpu_features_library | |
| # https://github.com/google/cpu_features#android-ndks-drop-in-replacement |
There was a problem hiding this comment.
Usually we don't add such details to the code, only short comments where needed. All that information is also in the commit message, so it does not get lost.
Reference: https://github.com/Kitware/CMake/blob/master/Modules/Platform/Android-Determine.cmake https://android.googlesource.com/platform/ndk/+/master/build/cmake/android.toolchain.cmake https://developer.android.com/ndk/guides/cpu-features#the_google_cpu_features_library https://github.com/google/cpu_features#android-ndks-drop-in-replacement
…_features-library
|
thanks |
|
I don't think we should add https://stackoverflow.com/questions/15328751/android-macro-suddenly-not-defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3680
Reference:
https://github.com/Kitware/CMake/blob/master/Modules/Platform/Android-Determine.cmake
https://android.googlesource.com/platform/ndk/+/master/build/cmake/android.toolchain.cmake
https://developer.android.com/ndk/guides/cpu-features#the_google_cpu_features_library
https://github.com/google/cpu_features#android-ndks-drop-in-replacement