Unittest: Fix Thai valid text and add Thai illegal sequences #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a invalid sequence in "valid text" `kScriptText` - Add two illegal sequence in `kBadlyFormedThaiWords`
bact
changed the title
|
@Shreeshrii : Are you able to check this PR? |
|
@zdenop @Shreeshrii thank you. I edited the descrption above, added the explanation. |
|
thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in "valid text"
kScriptTextAdd two illegal sequence in
kBadlyFormedThaiWordsThe code was:
proposed:
First one added is an illegal sequence of "น้ำ" (water)
The legal sequence for is
(0E19)+ ้(0E49)+ ำ(0E33)but sometimes found in this sequence (wrong order, and sometimes can be rendered visually similar)
(0E19)+ ำ(0E33)+ ้(0E49)Second one added is an illegal sequence of "แก" (you)
The legal sequence for is
(0E41)+ ก(0E01)sometimes found in this sequence (use two
0E40s instead of0E41, visually similar)(0E40)+ เ(0E40)+ ก(0E01)