Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in vault_jwt_auth_backend_role when bound_audiences is nil #763

Merged
merged 2 commits into from
May 20, 2020
Merged

Fix crash in vault_jwt_auth_backend_role when bound_audiences is nil #763

merged 2 commits into from
May 20, 2020

Conversation

dhduvall
Copy link
Contributor

Closes #595

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

catsby
catsby approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thank you!

@catsby catsby merged commit b34df66 into hashicorp:master May 20, 2020
@catsby catsby mentioned this pull request May 20, 2020
Closed
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@dhduvall
Fix crash in vault_jwt_auth_backend_role when bound_audiences is nil (h…
4d1b8fe 
…ashicorp#763)

* Fix crash in vault_jwt_auth_backend_role when bound_audiences is nil

Fixes hashicorp#595

* Restore drift detection on `bound_audiences`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash importing vault_jwt_auth_backend_role if bound_audiences is nil
2 participants
@dhduvall @catsby