Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth_backend data source #606

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Add auth_backend data source #606

merged 2 commits into from
Dec 6, 2019

Conversation

adongy
Copy link
Contributor

@adongy adongy commented Nov 14, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Add support for querying vault_auth_backend data with a datasource.
Some resources need the auth backend accessor (e.g. for identity groups). If it's managed outside Terraform, we can query the accessor through this datasource.

Release note for CHANGELOG:

Add `vault_auth_backend` datasource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestDataSourceAuthBackend'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestDataSourceAuthBackend -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	0.008s [no tests to run]
=== RUN   TestDataSourceAuthBackend
--- PASS: TestDataSourceAuthBackend (0.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	0.217s

@adongy adongy force-pushed the adong/add_auth_backend_data_source branch from b49b678 to 3532a2a Compare November 26, 2019 08:54
@adongy
Copy link
Contributor Author

adongy commented Nov 26, 2019

Test failures seem unrelated.

@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Dec 5, 2019
tyrannosaurus-becks
tyrannosaurus-becks reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adongy , thanks for working on this!

I have a question. I notice that we already have something close to this available as a resource versus a data source. For other data sources, I can more easily see why one would be pulling data from Vault into their Terraform config. Like, for instance, I could see someone using the AWS data source to get an AWS access key and secret for Terraform to use in spinning up infrastructure.

I don't quite imagine the use case for this one. Can you fill me in?

@adongy
Copy link
Contributor Author

adongy commented Dec 5, 2019

Hey @tyrannosaurus-becks,

Thanks for the review!

My use case is for bootstrapping Vault configuration. In my case, to avoid doing a manual "first time" Terraform configuration with a root token, I run a bootstrap script that registers some basic config.

In my case, I register an admin policy, as well as a OIDC mount to allow GSuite admin users to login and get that policy. After that, I can revoke the initial root token, and work from short lived tokens.

Through that bootstrap script, the OIDC mount is created, and I'd like to reuse it to allow non-admin users to also login through that auth backend. This config is managed through Vault identities, aliases shenanigans are used so it's a bit more complex.

tyrannosaurus-becks
tyrannosaurus-becks reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks really awesome. Just a couple questions about which way we want to go on this, drilling into one item vs. reading them all.

vault/data_source_auth_backend.go Show resolved Hide resolved
vault/data_source_auth_backend.go Show resolved Hide resolved
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for adding it, much appreciated!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 83d6d4d into hashicorp:master Dec 6, 2019
@adongy adongy deleted the adong/add_auth_backend_data_source branch December 8, 2019 09:51
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@tyrannosaurus-becks
Merge pull request hashicorp#606 from adongy/adong/add_auth_backend_d…
d41b3d0 
…ata_source

Add auth_backend data source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawliet89 lawliet89 lawliet89 left review comments

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adongy @lawliet89 @tyrannosaurus-becks