Remove aws_db_instance_readable_password rule #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related discussions of sensitive properties that shouldn't be hardcoded if we ever figure out how to re-write this rule: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my current opinion, the
aws_db_instance_readable_passwordrule makes no sense.For example, the following way is recommended to handle sensitive values:
https://learn.hashicorp.com/terraform/getting-started/variables.html#from-a-file
However, the
aws_db_instance_readable_passwordloads the local secret variable file even if the file is outside of version control. As a result, the rule reports a warning. This is wrong.In addition to this, current TFLint cannot accurately determine whether sensitive values are handled correctly. So, remove this rule to avoid confusing users.