terraform: Add support for Terraform v1.2 syntax #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraform.DefaultVariableValues is removed in this commit: hashicorp/terraform@36c4d4c This removes the redundant code, but the implementation itself is not wrong, so move it to the tflint package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1388
See also https://github.com/hashicorp/terraform/releases/tag/v1.2.0 https://github.com/hashicorp/terraform/releases/tag/v1.2.1
This PR updates the bundled Terraform's internal packages version to v1.2.1 from v1.1.
This will allow you to use the new keywords such as
precondition,postcondition, andreplace_triggered_byadded in v1.2.Most of these changes were completed by simply copying the Terraform package, but it's worth noting that
terraform.DefaultVariableValueshas been removed in this commit.However, if you look at the history of the change, it looks like it was removed when the Terraform core team removed the redundant variable merge logic, so this function itself is not a problem. So, we have moved this function under the tflint package and referenced it. There are no changes to the implementation.