tflint: Fix panic when encoding empty body #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes terraform-linters/tflint-plugin-sdk#115
When encoding HCL bodies for sending to a plugin, the range of blocks is calculated from the contents of the body. However, if the body is empty, an empty range will be the return value of the
HCLBodyRangefunc because there is no target range. Since the empty range doesn't have a filename, panic will occur when slicing source code bytes from the range:tflint/plugin/encode.go
Line 143 in 015b01c
This PR avoids this panic by always setting the filename, even if the body is empty.