Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wrapper to expose stdout, stderr, and exitcode #173

Closed
wants to merge 21 commits into from
Closed

add wrapper to expose stdout, stderr, and exitcode #173

wants to merge 21 commits into from

Conversation

dreinhardt89
Copy link
Contributor

Installing a wrapper script to wrap subsequent calls of the terraform binary and expose its STDOUT, STDERR, and exit code as outputs named stdout, stderr, and exitcode respectively. This is turned off by default.

@dreinhardt89 dreinhardt89 mentioned this pull request Jun 8, 2023
Closed
bendrucker
bendrucker requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@bendrucker bendrucker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple comments but I recognize that this is mostly borrowed from hashicorp/setup-terraform and kept the requests minimal.

.github/workflows/test.yml Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
dist/index1.js Outdated Show resolved Hide resolved
src/setup-tflint.js Outdated Show resolved Hide resolved
src/setup-tflint.js Outdated Show resolved Hide resolved
wrapper/tflint.js Outdated Show resolved Hide resolved
wrapper/tflint.js Outdated Show resolved Hide resolved
dreinhardt89 and others added 5 commits June 13, 2023 10:25
@dreinhardt89 @bendrucker
Update action.yml
3e482e9 
Co-authored-by: Ben Drucker <bvdrucker@gmail.com>
@dreinhardt89 @bendrucker
Update src/setup-tflint.js
77a9c85 
Co-authored-by: Ben Drucker <bvdrucker@gmail.com>
@dreinhardt89
fix: remove files
2adfadf
@dreinhardt89
fix: add assertion to integration test
3a0df39
@dreinhardt89
fix: forgot to build
0e13013
@dreinhardt89 dreinhardt89 requested a review from bendrucker June 21, 2023 18:32
@bendrucker bendrucker changed the title feat: add wrapper to tflint to expose stdout, stderr, and exitcode feat: add wrapper to expose stdout, stderr, and exitcode Jun 23, 2023
@bendrucker bendrucker changed the title feat: add wrapper to expose stdout, stderr, and exitcode add wrapper to expose stdout, stderr, and exitcode Aug 24, 2023
@bendrucker bendrucker added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendrucker bendrucker Awaiting requested review from bendrucker

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreinhardt89 @bendrucker