Node pool create: add an implicit dependency on parent cluster #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explicit `depends_on` is not required as there are other ways to signal to Terraform that a resource depends on another. Implicit dependencies are more like TF usually operates.
JordanP
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
|
Note for posterity: The integration CI failure appears spurious: |
aaron-lane
previously approved these changes
Feb 11, 2019
adrienthebo
suggested changes
Mar 13, 2019
There was a problem hiding this comment.
@JordanP thanks for making this change! The autogen and root level modules look good, but it doesn't look like this change has propagated to modules/private-cluster. Could you run make generate and see if that updates the private cluster module with the implicit dependency?
morgante
approved these changes
Mar 27, 2019
aaron-lane
added a commit
that referenced
this pull request
Apr 4, 2019
aaron-lane
added a commit
that referenced
this pull request
Apr 4, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…depends_on Node pool create: add an implicit dependency on parent cluster
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit
depends_onis not required as there are other waysto signal to Terraform that a resource depends on another. Implicit
dependencies are more like TF usually operates.