Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Z3Counterexamples.lean, with a counterexample found by z3 #291

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

dwrensha
Copy link
Contributor

@dwrensha dwrensha commented Oct 4, 2024

Resolves a new edge that is still not covered by #281, plus 5 more by transitivity.

Includes in a comment the z3 spec that I ran, which involved bit vectors of length 3.
When I tried the same thing with bit vectors of length 2, z3 said it was unsatisfiable.

@teorth
Copy link
Owner

teorth commented Oct 4, 2024

Is it worth adding this counterexample to an existing lists of finite magmas?

@dwrensha
Copy link
Contributor Author

dwrensha commented Oct 5, 2024

The list I am aware of is in SmallMagmas.lean, and this magma did not seem appropriate for there ("This file defines some trivially small magmas...").

Your comment did prompt me to learn about calculate_facts, which does indeed find some more edges where this magma helps, but in a highly verbose form that needs reduction. Since I don't have time to reduce the output of calculate_facts right now, I just added a TODO here about trying calculate_facts on this magma.

@teorth teorth merged commit d99988d into teorth:main Oct 5, 2024
2 checks passed
@dwrensha dwrensha deleted the z3-counterexamples branch October 5, 2024 02:41
teorth pushed a commit that referenced this pull request Oct 5, 2024
Cleans up the counterexample added in #291 and perhaps makes it easier
to add to the existing infrastructure for finite magmas, under
`equational_theories/Generated/All4x4Tables`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants