-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homomorphisms and isomorphisms #158
Conversation
Out of the last four definitions (MagmaHom.toMagmaEquiv), we don't want all of them. |
awaiting-review |
I guess we should follow whatever Mathlib does for the analogous [Mul] and [Add] homomorphisms with regards to making equivalences. By the way, if you could also update the top-level |
You could add a poll to the zulip poll thread to see if there are any strong feelings on this issue |
I will add more API tomorrow. |
Actually with the likely refactor in which Magma may become closer to Mul this PR may become obsolete. Stay tuned... |
There wasn't enough consensus to move from Magma to Mul, so I think we will go ahead with your PR after all. It looks like you selected a |
All right, the PR is ready for review now. |
null
Closes #114