Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homomorphisms and isomorphisms #158

Merged
merged 10 commits into from
Oct 3, 2024
Merged

homomorphisms and isomorphisms #158

merged 10 commits into from
Oct 3, 2024

Conversation

madvorak
Copy link
Contributor

@madvorak madvorak commented Oct 1, 2024

null

Closes #114

@madvorak
Copy link
Contributor Author

madvorak commented Oct 1, 2024

Out of the last four definitions (MagmaHom.toMagmaEquiv), we don't want all of them.
Please tell me which one or two we should keep.

@madvorak
Copy link
Contributor Author

madvorak commented Oct 1, 2024

awaiting-review

@github-actions github-actions bot added the awaiting-review the PR passes CI and is ready for review label Oct 1, 2024
@teorth
Copy link
Owner

teorth commented Oct 1, 2024

I guess we should follow whatever Mathlib does for the analogous [Mul] and [Add] homomorphisms with regards to making equivalences.

By the way, if you could also update the top-level equational_theories.lean to include your new file, and also add a description of your file to the core lean files listed in CONTRIBUTING.md, that would be great.

@teorth
Copy link
Owner

teorth commented Oct 1, 2024

You could add a poll to the zulip poll thread to see if there are any strong feelings on this issue

@madvorak
Copy link
Contributor Author

madvorak commented Oct 1, 2024

I will add more API tomorrow.

@teorth
Copy link
Owner

teorth commented Oct 1, 2024

Actually with the likely refactor in which Magma may become closer to Mul this PR may become obsolete. Stay tuned...

@teorth
Copy link
Owner

teorth commented Oct 3, 2024

There wasn't enough consensus to move from Magma to Mul, so I think we will go ahead with your PR after all. It looks like you selected a MagmaHom.toMagmaEquiv, so all we need to do now is fix the conflict with CONTRIBUTING.md and we are good to merge!

@madvorak
Copy link
Contributor Author

madvorak commented Oct 3, 2024

All right, the PR is ready for review now.

@teorth teorth merged commit 198f326 into teorth:main Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review the PR passes CI and is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Develop an API for homomorphisms and isomorphisms between magmas
2 participants