Fix rollup bundles and update versions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsthorat
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nsthorat and @pyu10055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#237, #243 & #233 updated the peer dependencies of our models to be core and converter instead of the union.
However since the rollup config was not updated, this resulted in published model's bundles to include the whole tfjs-core and tfjs-converter. E.g. https://unpkg.com/@tensorflow-models/coco-ssd@1.1.0/dist/coco-ssd.min.js is ~577KB but should be ~27KB.
After this change, I will re-release patch versions of the updated models.
This change is