Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Against TF 2.10 #2744

Merged
merged 58 commits into from
Sep 20, 2022
Merged

Build Against TF 2.10 #2744

merged 58 commits into from
Sep 20, 2022

Conversation

seanpmorgan
Copy link
Member

Description

  • Need to update windows builds
  • Waiting for arm macos build

Brief Description of the PR:

Type of change

@boring-cyborg boring-cyborg bot added the github label Aug 7, 2022
@seanpmorgan seanpmorgan changed the title [WIP] Build Against TF 2.10rc0 [WIP] Build Against TF 2.10rc2 Aug 24, 2022
@bhack
Copy link
Contributor

bhack commented Aug 24, 2022

@nicolaspi
Copy link
Contributor

@bhack I am on it.

@nicolaspi
Copy link
Contributor

@bhack Please check #2751. It should fix it.

@bhack
Copy link
Contributor

bhack commented Aug 24, 2022

@bhack Please check #2751. It should fix it.

Thanks, let's see the new CI run..

@boring-cyborg boring-cyborg bot added the build label Aug 25, 2022
@bhack
Copy link
Contributor

bhack commented Sep 6, 2022

🟢 Green-light here, waiting for the MacOS delayed release:
https://pypi.org/project/tensorflow-macos/#history

@lgeiger
Copy link
Contributor

lgeiger commented Sep 16, 2022

🟢 Green-light here, waiting for the MacOS delayed release:

Looks like 2.10.0 was just released yesterday: https://pypi.org/project/tensorflow-macos

@bhack
Copy link
Contributor

bhack commented Sep 16, 2022

I don't the story about arm and non arm MacOS diversification we had.
Can we align all to MacOS 12? Al the new tensorflow-macos wheels are 12 only.

@seanpmorgan seanpmorgan changed the title [WIP] Build Against TF 2.10 Build Against TF 2.10 Sep 19, 2022
@seanpmorgan seanpmorgan changed the title Build Against TF 2.10 [WIP] Build Against TF 2.10 Sep 20, 2022
@seanpmorgan
Copy link
Member Author

I don't the story about arm and non arm MacOS diversification we had. Can we align all to MacOS 12? Al the new tensorflow-macos wheels are 12 only.

The tensorflow wheels are still supporting 10_14:
https://pypi.org/project/tensorflow/2.10.0/#files

@bhack
Copy link
Contributor

bhack commented Sep 20, 2022

This policy is confusing me a bit.
What are the differences between TF MacOS and Tensorflow-macos for X64? Do they have the same features?

As tensorflow-macos is MacOS 12 only for TF 2.10

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Sep 20, 2022

This policy is confusing me a bit. What are the differences between TF MacOS and Tensorflow-macos for X64? Do they have the same features?

As tensorflow-macos is MacOS 12 only for TF 2.10

Same. tensorflow-macos just started adding x86 wheels on TF2.9. I'm not sure what optimization they provide for those chips or why you would install that package instead of TF. For now I'm just going to keep our macos_x86_64 built with macOS 10 since TF is still providing those wheels and I don't have justification for telling users to force an OS upgrade and switch to tensorflow-macos for non-ARM chipsets. They also don't build py37 wheels

Hopefully they align on what's supported.

@lgeiger
Copy link
Contributor

lgeiger commented Sep 20, 2022

For now I'm just going to keep our macos_x86_64 built with macOS 10 since TF is still providing those wheels and I don't have justification for telling users to force an OS upgrade and switch to tensorflow-macos for non-ARM chipsets.

Sounds great.
Just for reference since I am not sure how long GitHub will still support 10.15 macOS images: it is possible to build backwards compatible wheels on the latest macOS by setting --copt=-mmacosx-version-min=10.14 --linkopt=-mmacosx-version-min=10.14 as bazel flags or via the MACOSX_DEPLOYMENT_TARGET env variable.

@bhack
Copy link
Contributor

bhack commented Sep 20, 2022

It would be nice if @jhavukainen or @kulinseth could clarify on this.

@seanpmorgan
Copy link
Member Author

For now I'm just going to keep our macos_x86_64 built with macOS 10 since TF is still providing those wheels and I don't have justification for telling users to force an OS upgrade and switch to tensorflow-macos for non-ARM chipsets.

Sounds great. Just for reference since I am not sure how long GitHub will still support 10.15 macOS images: it is possible to build backwards compatible wheels on the latest macOS by setting --copt=-mmacosx-version-min=10.14 --linkopt=-mmacosx-version-min=10.14 as bazel flags or via the MACOSX_DEPLOYMENT_TARGET env variable.

Ack, it appears to be imminent:
actions/runner-images#5583

Will upgrade the build OS, since the compilation settings are still here:
https://github.com/tensorflow/addons/blob/master/.github/workflows/make_wheel_macOS_x86.sh#L19-L20

@seanpmorgan seanpmorgan changed the title [WIP] Build Against TF 2.10 Build Against TF 2.10 Sep 20, 2022
Co-authored-by: Lukas Geiger <lukas.geiger94@gmail.com>
@seanpmorgan seanpmorgan requested a review from bhack September 20, 2022 23:24
@seanpmorgan seanpmorgan merged commit 2e772fd into tensorflow:master Sep 20, 2022
@seanpmorgan seanpmorgan deleted the build-tf210 branch September 20, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build github test-cases Related to Addons tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants