Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add command to manually reindex tx and block events (backport: #6676) #9034

Merged
merged 6 commits into from
Jul 22, 2022

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented Jul 18, 2022

This is a backport of #6676 which adds a new cli to reindex missed blocks (if the node has the respective ABCIResponses)

This will help node operators who offer indexing service the ability to reindex missed events i.e. in the case their node goes down

@tac0turtle tac0turtle changed the base branch from master to v0.34.x July 18, 2022 23:04
@creachadair
Copy link

Note that if #8946 is implemented, it will make reindexing stop working for blocks prior to the latest. That's not necessarily a blocker to doing it, but it's worth considering the interaction.

@tac0turtle
Copy link
Contributor Author

ah good point, It seems like the abciresponses would move to a abci.db and be optional to not bloat state.db. For archive nodes they may opt to store those and provide snapshots to others to reindex data.

@cmwaters
Copy link
Contributor

This will still be a configurable option. Users will be able to save ABCI responses if they want which will allow them to reindex missed blocks. I assume those running indexers probably care less about minimizing storage.

@cmwaters cmwaters self-assigned this Jul 21, 2022
@cmwaters
Copy link
Contributor

Have a test that's not passing because apparently an incorrect connection url is given to the postgres instance but no error is returned when one is expected

@cmwaters cmwaters changed the title backport: reindex api cli: add command to manually reindex tx and block events (backport: #6676) Jul 22, 2022
@cmwaters cmwaters marked this pull request as ready for review July 22, 2022 13:35
@cmwaters
Copy link
Contributor

One minor difference here to the original backport is that v0.34 only supports a single indexer whereas v0.35+ supports multiple

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@cmwaters cmwaters merged commit 46badfa into v0.34.x Jul 22, 2022
@cmwaters cmwaters deleted the marko/reindex-backport branch July 22, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants