crypto: API modifications #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5236 +/- ##
==========================================
+ Coverage 60.83% 61.41% +0.57%
==========================================
Files 203 198 -5
Lines 20446 23083 +2637
==========================================
+ Hits 12439 14176 +1737
- Misses 6938 7657 +719
- Partials 1069 1250 +181
|
erikgrinaker
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make the crypto.PubKey interface more intuitive.
Changes:
VerfiyBytes->VerifySignatureBefore
Bytes()was amino encoded, now since it is the byte representation should we get rid of it entirely?EDIT: decided to keep
Bytes()as it is useful if you are using the interface instead of the concrete keyCloses: #XXX