Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: replace Amino with new JSON encoder #4968

Merged
merged 5 commits into from
Jun 8, 2020
Merged

rpc: replace Amino with new JSON encoder #4968

merged 5 commits into from
Jun 8, 2020

Conversation

erikgrinaker
Copy link
Contributor

Migrates the rpc package to use new JSON encoder in #4955. Branched off of that PR.

Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing.

@erikgrinaker erikgrinaker added C:rpc Component: JSON RPC, gRPC T:encoding Type: Amino, ProtoBuf R:major PR contains breaking changes that have to wait till a major release is made to be merged labels Jun 5, 2020
@erikgrinaker erikgrinaker requested a review from tac0turtle June 5, 2020 12:33
@erikgrinaker erikgrinaker self-assigned this Jun 5, 2020
@auto-comment
Copy link

auto-comment bot commented Jun 5, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@codecov
Copy link

codecov bot commented Jun 5, 2020 •
edited
Loading

Codecov Report

Merging #4968 into master will increase coverage by 0.09%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##           master    #4968      +/-   ##
==========================================
+ Coverage   63.42%   63.52%   +0.09%     
==========================================
  Files         176      176              
  Lines       16509    16498      -11     
==========================================
+ Hits        10471    10480       +9     
+ Misses       5157     5138      -19     
+ Partials      881      880       -1
Impacted Files Coverage Δ
cmd/tendermint/commands/lite.go 23.07% <ø> (+0.29%) ⬆️
light/rpc/client.go 0.00% <ø> (ø)
rpc/core/events.go 0.00% <ø> (ø)
rpc/core/routes.go 0.00% <ø> (ø)
rpc/jsonrpc/client/decode.go 5.17% <0.00%> (ø)
rpc/jsonrpc/client/http_json_client.go 12.08% <0.00%> (+0.23%) ⬆️
rpc/jsonrpc/client/http_uri_client.go 0.00% <0.00%> (ø)
rpc/jsonrpc/client/encode.go 47.82% <50.00%> (ø)
rpc/jsonrpc/client/ws_client.go 58.00% <50.00%> (+0.29%) ⬆️
crypto/ed25519/ed25519.go 46.00% <100.00%> (+3.44%) ⬆️
... and 6 more

@erikgrinaker erikgrinaker mentioned this pull request Jun 5, 2020
Merged
tac0turtle
tac0turtle approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

melekes
melekes approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🐎

Base automatically changed from erik/migrate-json-amino to master June 8, 2020 11:42
@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Jun 8, 2020
@mergify mergify bot merged commit ba3a2dd into master Jun 8, 2020
@mergify mergify bot deleted the erik/rpc-json branch June 8, 2020 12:04
@erikgrinaker erikgrinaker mentioned this pull request Jun 8, 2020
Closed
8 tasks
mergify bot pushed a commit that referenced this pull request Jun 8, 2020
@erikgrinaker
migrate all JSON to new JSON encoder (#4975)
db8f1b3 
Uses new JSON encoder in #4955 for all JSON. Branched off of #4968.
@gibson042 gibson042 mentioned this pull request Aug 3, 2022
Closed
@gibson042 gibson042 mentioned this pull request Mar 27, 2023
Closed
@gibson042 gibson042 mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes

@tac0turtle tac0turtle

@tessr tessr

Assignees

@erikgrinaker erikgrinaker

Labels
C:rpc Component: JSON RPC, gRPC R:major PR contains breaking changes that have to wait till a major release is made to be merged S:automerge Automatically merge PR when requirements pass T:encoding Type: Amino, ProtoBuf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikgrinaker @melekes @tac0turtle