Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc/core: return an error if page=0 #4947

Merged
merged 8 commits into from
Jun 3, 2020
Merged

rpc/core: return an error if page=0 #4947

merged 8 commits into from
Jun 3, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jun 3, 2020

Closes #4942

affected endpoints:

  • /validators
  • /tx_search

@melekes melekes requested a review from tessr as a code owner June 3, 2020 11:51
@auto-comment
Copy link

auto-comment bot commented Jun 3, 2020 •
edited by melekes
Loading

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes self-assigned this Jun 3, 2020
@melekes melekes added the R:minor Release: Minor label Jun 3, 2020
erikgrinaker
erikgrinaker approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Needs a changelog entry, since it's a breaking API change.

@melekes
Copy link
Contributor Author

melekes commented Jun 3, 2020

oops, sorry. I meant to open a draft PR @erikgrinaker. but it should be ready now.

erikgrinaker
erikgrinaker approved these changes Jun 3, 2020
View reviewed changes
@melekes melekes added R:major PR contains breaking changes that have to wait till a major release is made to be merged and removed R:minor Release: Minor labels Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020 •
edited
Loading

Codecov Report

Merging #4947 into master will increase coverage by 0.04%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##           master    #4947      +/-   ##
==========================================
+ Coverage   63.27%   63.31%   +0.04%     
==========================================
  Files         188      188              
  Lines       19549    19564      +15     
==========================================
+ Hits        12369    12387      +18     
+ Misses       6190     6189       -1     
+ Partials      990      988       -2
Impacted Files Coverage Δ
light/rpc/client.go 0.00% <0.00%> (ø)
rpc/core/consensus.go 0.00% <0.00%> (ø)
rpc/core/mempool.go 0.00% <0.00%> (ø)
rpc/core/tx.go 0.00% <0.00%> (ø)
rpc/core/env.go 57.44% <100.00%> (+3.95%) ⬆️
statesync/snapshots.go 92.59% <0.00%> (-1.49%) ⬇️
crypto/random.go 50.00% <0.00%> (ø)
p2p/pex/addrbook.go 72.33% <0.00%> (ø)
consensus/state.go 72.30% <0.00%> (+0.55%) ⬆️
p2p/pex/pex_reactor.go 83.79% <0.00%> (+0.55%) ⬆️
... and 4 more

@melekes melekes merged commit ce3c9c2 into master Jun 3, 2020
@melekes melekes deleted the anton/4942-page-0 branch June 3, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker

@tessr tessr

Assignees

@melekes melekes

Labels
R:major PR contains breaking changes that have to wait till a major release is made to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

q tendermint-validator-set --limit 100 --page 0 returns same result as page 1
2 participants
@melekes @erikgrinaker