Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statesync: use Protobuf instead of Amino for p2p traffic #4943

Merged
merged 3 commits into from
Jun 3, 2020
Merged

statesync: use Protobuf instead of Amino for p2p traffic #4943

merged 3 commits into from
Jun 3, 2020

Conversation

tac0turtle
Copy link
Contributor

Description

Closes: #XXX

@tac0turtle tac0turtle added C:sync Component: Fast Sync, State Sync S:automerge Automatically merge PR when requirements pass labels Jun 3, 2020
@tac0turtle tac0turtle self-assigned this Jun 3, 2020
@auto-comment
Copy link

auto-comment bot commented Jun 3, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #4943 into master will decrease coverage by 0.04%.
The diff coverage is 86.15%.

@@            Coverage Diff             @@
##           master    #4943      +/-   ##
==========================================
- Coverage   62.77%   62.72%   -0.05%     
==========================================
  Files         197      197              
  Lines       20076    20097      +21     
==========================================
+ Hits        12602    12606       +4     
- Misses       6447     6465      +18     
+ Partials     1027     1026       -1
Impacted Files Coverage Δ
statesync/reactor.go 41.81% <71.42%> (ø)
statesync/messages.go 86.20% <87.50%> (-8.39%) ⬇️
statesync/syncer.go 79.44% <100.00%> (ø)
consensus/ticker.go 91.66% <0.00%> (-4.17%) ⬇️
blockchain/v2/reactor.go 35.35% <0.00%> (-2.55%) ⬇️
consensus/reactor.go 72.99% <0.00%> (-0.59%) ⬇️
consensus/state.go 73.26% <0.00%> (ø)
blockchain/v0/pool.go 78.98% <0.00%> (+0.31%) ⬆️
p2p/conn/connection.go 79.69% <0.00%> (+0.77%) ⬆️

@tac0turtle tac0turtle marked this pull request as ready for review June 3, 2020 08:41
@tac0turtle tac0turtle requested review from melekes and tessr as code owners June 3, 2020 08:41
@tac0turtle tac0turtle requested a review from erikgrinaker June 3, 2020 08:41
@mergify mergify bot merged commit 4e6a844 into master Jun 3, 2020
@mergify mergify bot deleted the proto/state_sync branch June 3, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker

@melekes melekes

@tessr tessr

Assignees

@tac0turtle tac0turtle

Labels
C:sync Component: Fast Sync, State Sync S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tac0turtle @erikgrinaker