rpc: add BlockByHash to supported methods #4923
Merged
+103
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4923 +/- ##
==========================================
- Coverage 62.86% 62.69% -0.17%
==========================================
Files 198 198
Lines 20013 20041 +28
==========================================
- Hits 12581 12565 -16
- Misses 6406 6447 +41
- Partials 1026 1029 +3
|
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.
BlockByHashto supported rpc Client methods.Problem
Ethermint currently has to maintain a map
height->block hashon the store (see here) as it needs to expose theeth_getBlockByHashJSON-RPC query for Web3 compatibility. This query is currently not supported by the tendermint RPC client.