light: implement validate basic #4916
Merged
+126
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4916 +/- ##
==========================================
+ Coverage 63.23% 63.36% +0.12%
==========================================
Files 188 188
Lines 19566 19587 +21
==========================================
+ Hits 12373 12411 +38
+ Misses 6203 6191 -12
+ Partials 990 985 -5
|
cmwaters
changed the title
melekes
reviewed
May 29, 2020
lite2/client.go
Outdated
| @@ -1052,10 +1053,32 @@ func (c *Client) signedHeaderFromPrimary(height int64) (*types.SignedHeader, err | |||
| h, err := c.primary.SignedHeader(height) | |||
| c.providerMutex.Unlock() | |||
| if err == nil { | |||
| if h == nil { | |||
There was a problem hiding this comment.
can we extract this and the next conditions into a function?
func validateHeader(h *Header, expectedHeight int64) error {
if h == nil { return errors.New("nil header")}
if (expectedHeight > 0 && h.Height != expectedHeight) { return errors.New("height mismatch")
return h.ValidateBasic(c.chainID)
}
lite2/client.go
Outdated
| @@ -1082,17 +1104,35 @@ func (c *Client) validatorSetFromPrimary(height int64) (*types.ValidatorSet, err | |||
| c.providerMutex.Lock() | |||
| vals, err := c.primary.ValidatorSet(height) | |||
| c.providerMutex.Unlock() | |||
| if err == nil || err == provider.ErrValidatorSetNotFound { | |||
| if err == nil { | |||
| if vals == nil { | |||
melekes
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added validate basic to the light client and wrote tests accordingly
I also tried to improve the error messages as when the providers have all been replaced the user doesn't know what the existing error that caused them to be replaced is
Addresses: #4913