Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci/server: print panic & stack trace to STDERR if logger is not set #4719

Merged
merged 8 commits into from
Apr 22, 2020
Merged

abci/server: print panic & stack trace to STDERR if logger is not set #4719

merged 8 commits into from
Apr 22, 2020
+33 −19

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Apr 22, 2020 •
edited
Loading

Closes #4382

@melekes melekes requested a review from tessr as a code owner April 22, 2020 10:25
@melekes melekes self-assigned this Apr 22, 2020
@melekes melekes added C:abci Component: Application Blockchain Interface R:minor Release: Minor labels Apr 22, 2020
@codecov-io
Copy link

codecov-io commented Apr 22, 2020 •
edited
Loading

Codecov Report

Merging #4719 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4719      +/-   ##
==========================================
+ Coverage   65.82%   65.87%   +0.04%     
==========================================
  Files         221      221              
  Lines       19996    19996              
==========================================
+ Hits        13163    13172       +9     
+ Misses       5777     5769       -8     
+ Partials     1056     1055       -1
Impacted Files Coverage Δ
crypto/sr25519/pubkey.go 32.14% <0.00%> (-7.15%) ⬇️
p2p/pex/pex_reactor.go 82.72% <0.00%> (-1.12%) ⬇️
consensus/replay.go 72.86% <0.00%> (-0.78%) ⬇️
consensus/reactor.go 79.49% <0.00%> (ø)
consensus/state.go 74.85% <0.00%> (+0.09%) ⬆️
blockchain/v0/pool.go 78.98% <0.00%> (+0.31%) ⬆️
libs/clist/clist.go 68.18% <0.00%> (+1.51%) ⬆️
blockchain/v2/reactor.go 39.34% <0.00%> (+4.09%) ⬆️
privval/signer_server.go 100.00% <0.00%> (+4.34%) ⬆️

erikgrinaker
erikgrinaker reviewed Apr 22, 2020
View reviewed changes
@melekes melekes added the S:automerge Automatically merge PR when requirements pass label Apr 22, 2020
@melekes melekes changed the title abci/server: use stdlib logger by default abci/server: print panic & stack trace to STDERR if no logger is set Apr 22, 2020
@melekes melekes changed the title abci/server: print panic & stack trace to STDERR if no logger is set abci/server: print panic & stack trace to STDERR if logger is not set Apr 22, 2020
@mergify mergify bot merged commit 33a19da into master Apr 22, 2020
@mergify mergify bot deleted the anton/4382-abci-server-recover branch April 22, 2020 11:42
@tessr tessr removed the R:minor Release: Minor label May 27, 2020
@ashleyvega ashleyvega mentioned this pull request Jun 3, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker

@tessr tessr

Assignees

@melekes melekes

Labels
C:abci Component: Application Blockchain Interface S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error and stack trace may be hidden in SocketServer if panic happen in ABCI app code.
4 participants
@melekes @codecov-io @erikgrinaker @tessr